Passing non-existent credentials should return null user #220

AfzalivE · 2014-02-11T00:43:15Z

In getUserByIdentity, passing some credentials that don't exist like "token" actually returned a valid user when it shouldn't.

This commit fixes this behaviour.

Also reverted the previous commit which tried to fix #215 , that behaviour was also caused by this problem and seems to be fixed now.

This reverts commit f145dee.

Fixed Zizaco#215

vgoodvin · 2014-02-18T18:57:44Z

+1
When I pass wrong credentials to ConfideEloquentRepository::getUserByIdentity() it returns first user from DB.
Example credentials:

array(
    'email'    => null,
    'username' => null,
);

@AfzalivE

Passing non-existent credentials should return null user. Thanks @AfzalivE

This prevents the breaking change that was implemented with #220

AfzalivE added 2 commits February 10, 2014 19:33

Revert "Check for empty identity_columns after array_diff"

c8c38b7

This reverts commit f145dee.

Passing nonexistent credentials should return null

7b6fa97

Fixed Zizaco#215

andrew13 added a commit that referenced this pull request Feb 18, 2014

Merge pull request #220 from AfzalivE/master

17ce63e

Passing non-existent credentials should return null user. Thanks @AfzalivE

andrew13 merged commit 17ce63e into Zizaco:master Feb 18, 2014

andrew13 added a commit that referenced this pull request Mar 12, 2014

Fix the check for creds vs ident columns

060e6ef

This prevents the breaking change that was implemented with #220

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Passing non-existent credentials should return null user #220

Passing non-existent credentials should return null user #220

AfzalivE commented Feb 11, 2014

vgoodvin commented Feb 18, 2014

Passing non-existent credentials should return null user #220

Passing non-existent credentials should return null user #220

Conversation

AfzalivE commented Feb 11, 2014

vgoodvin commented Feb 18, 2014